Heights and widths no round to 6 decimal places.
↧
Source code checked in, #6712cf78be394f19025c4458d7af5134a33f5775
↧
Closed Unassigned: Lots of tests fails [9422]
Hi
When I clone the source (Git hash: 4cbcac89e85eb03c9cf31ad4162e729db69a596f) and run the tests 95 of the tests fails.
I have not analyzed all of them, just picked the first: AddingDataSet:
```
Test Name: AddingDataSet
Test FullName: ClosedXML_Tests.Examples.MiscTests.AddingDataSet
Test Source: c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs : line 12
Test Outcome: Failed
Test Duration: 0:00:00.972
Result Message:
Actual file 'C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx' is different than the expected file 'Misc.AddingDataSet.xlsx'. The difference is: '/xl/styles.xml :NonEqual
/xl/worksheets/sheet.xml :NonEqual
/xl/worksheets/sheet2.xml :NonEqual
/xl/worksheets/sheet3.xml :NonEqual
'
Expected: True
But was: False
Result StackTrace:
at ClosedXML_Tests.TestHelper.RunTestExample[T](String filePartName) in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\TestHelper.cs:line 83
at ClosedXML_Tests.Examples.MiscTests.AddingDataSet() in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs:line 13
```
I unpacked the ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx and ClosedXML_Tests\Resource\Examples\Misc\AddingDataSet.xlsx by renaming them to zip, unpacking and then comparing them.
In /xl/styles.xml applyNumberFormat="1" is in the Debug... and applyNumberFormat="0" in the Resource...
The same with applyAlignment="1" vs applyAlignment="0".
In /xl/worksheets/sheet.xml and /xl/worksheets/sheet2.xml and /xl/worksheets/sheet3.xml there is the same difference
<x:col min="4" max="4" width="9.4906250000000014" style="0" customWidth="1" /> in Debug... and
<x:col min="4" max="4" width="9.830625" style="0" customWidth="1" /> in Resource...
Any ideas what might be wrong?
I tried changing locale to both en-US and en-GB without success, but since there are no textual differences in the files I suppose that would not be the case anyway.
Seems something in the environment could be the issue. But what?
Framework/OS version? Screen resolution?
I attached the output from the test written to C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx
Comments: Merged your PRs and made a few modifications. Mainly rounding heights and widths. Tests should now pass for any configuration. Let me know if you have any problems.
When I clone the source (Git hash: 4cbcac89e85eb03c9cf31ad4162e729db69a596f) and run the tests 95 of the tests fails.
I have not analyzed all of them, just picked the first: AddingDataSet:
```
Test Name: AddingDataSet
Test FullName: ClosedXML_Tests.Examples.MiscTests.AddingDataSet
Test Source: c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs : line 12
Test Outcome: Failed
Test Duration: 0:00:00.972
Result Message:
Actual file 'C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx' is different than the expected file 'Misc.AddingDataSet.xlsx'. The difference is: '/xl/styles.xml :NonEqual
/xl/worksheets/sheet.xml :NonEqual
/xl/worksheets/sheet2.xml :NonEqual
/xl/worksheets/sheet3.xml :NonEqual
'
Expected: True
But was: False
Result StackTrace:
at ClosedXML_Tests.TestHelper.RunTestExample[T](String filePartName) in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\TestHelper.cs:line 83
at ClosedXML_Tests.Examples.MiscTests.AddingDataSet() in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs:line 13
```
I unpacked the ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx and ClosedXML_Tests\Resource\Examples\Misc\AddingDataSet.xlsx by renaming them to zip, unpacking and then comparing them.
In /xl/styles.xml applyNumberFormat="1" is in the Debug... and applyNumberFormat="0" in the Resource...
The same with applyAlignment="1" vs applyAlignment="0".
In /xl/worksheets/sheet.xml and /xl/worksheets/sheet2.xml and /xl/worksheets/sheet3.xml there is the same difference
<x:col min="4" max="4" width="9.4906250000000014" style="0" customWidth="1" /> in Debug... and
<x:col min="4" max="4" width="9.830625" style="0" customWidth="1" /> in Resource...
Any ideas what might be wrong?
I tried changing locale to both en-US and en-GB without success, but since there are no textual differences in the files I suppose that would not be the case anyway.
Seems something in the environment could be the issue. But what?
Framework/OS version? Screen resolution?
I attached the output from the test written to C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx
Comments: Merged your PRs and made a few modifications. Mainly rounding heights and widths. Tests should now pass for any configuration. Let me know if you have any problems.
↧
↧
New Post: General performance improvements
I haven't profiled the library in a while. Create an issue and attach a program that creates a file with 500K cells that mimics the files you're creating. That way I wouldn't be profiling fake data.
Send your PRs as soon as you make an improvement. That way we'll avoid on huge merge at the end.
Thanks for the help,
Manuel
Send your PRs as soon as you make an improvement. That way we'll avoid on huge merge at the end.
Thanks for the help,
Manuel
↧
Commented Unassigned: Lots of tests fails [9422]
Hi
When I clone the source (Git hash: 4cbcac89e85eb03c9cf31ad4162e729db69a596f) and run the tests 95 of the tests fails.
I have not analyzed all of them, just picked the first: AddingDataSet:
```
Test Name: AddingDataSet
Test FullName: ClosedXML_Tests.Examples.MiscTests.AddingDataSet
Test Source: c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs : line 12
Test Outcome: Failed
Test Duration: 0:00:00.972
Result Message:
Actual file 'C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx' is different than the expected file 'Misc.AddingDataSet.xlsx'. The difference is: '/xl/styles.xml :NonEqual
/xl/worksheets/sheet.xml :NonEqual
/xl/worksheets/sheet2.xml :NonEqual
/xl/worksheets/sheet3.xml :NonEqual
'
Expected: True
But was: False
Result StackTrace:
at ClosedXML_Tests.TestHelper.RunTestExample[T](String filePartName) in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\TestHelper.cs:line 83
at ClosedXML_Tests.Examples.MiscTests.AddingDataSet() in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs:line 13
```
I unpacked the ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx and ClosedXML_Tests\Resource\Examples\Misc\AddingDataSet.xlsx by renaming them to zip, unpacking and then comparing them.
In /xl/styles.xml applyNumberFormat="1" is in the Debug... and applyNumberFormat="0" in the Resource...
The same with applyAlignment="1" vs applyAlignment="0".
In /xl/worksheets/sheet.xml and /xl/worksheets/sheet2.xml and /xl/worksheets/sheet3.xml there is the same difference
<x:col min="4" max="4" width="9.4906250000000014" style="0" customWidth="1" /> in Debug... and
<x:col min="4" max="4" width="9.830625" style="0" customWidth="1" /> in Resource...
Any ideas what might be wrong?
I tried changing locale to both en-US and en-GB without success, but since there are no textual differences in the files I suppose that would not be the case anyway.
Seems something in the environment could be the issue. But what?
Framework/OS version? Screen resolution?
I attached the output from the test written to C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx
Comments: Hi, it looks like https://closedxml.codeplex.com/SourceControl/network/forks/ericlamb/closedxml/contribution/7561#!/tab/comments broke the tests again.
When I clone the source (Git hash: 4cbcac89e85eb03c9cf31ad4162e729db69a596f) and run the tests 95 of the tests fails.
I have not analyzed all of them, just picked the first: AddingDataSet:
```
Test Name: AddingDataSet
Test FullName: ClosedXML_Tests.Examples.MiscTests.AddingDataSet
Test Source: c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs : line 12
Test Outcome: Failed
Test Duration: 0:00:00.972
Result Message:
Actual file 'C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx' is different than the expected file 'Misc.AddingDataSet.xlsx'. The difference is: '/xl/styles.xml :NonEqual
/xl/worksheets/sheet.xml :NonEqual
/xl/worksheets/sheet2.xml :NonEqual
/xl/worksheets/sheet3.xml :NonEqual
'
Expected: True
But was: False
Result StackTrace:
at ClosedXML_Tests.TestHelper.RunTestExample[T](String filePartName) in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\TestHelper.cs:line 83
at ClosedXML_Tests.Examples.MiscTests.AddingDataSet() in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs:line 13
```
I unpacked the ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx and ClosedXML_Tests\Resource\Examples\Misc\AddingDataSet.xlsx by renaming them to zip, unpacking and then comparing them.
In /xl/styles.xml applyNumberFormat="1" is in the Debug... and applyNumberFormat="0" in the Resource...
The same with applyAlignment="1" vs applyAlignment="0".
In /xl/worksheets/sheet.xml and /xl/worksheets/sheet2.xml and /xl/worksheets/sheet3.xml there is the same difference
<x:col min="4" max="4" width="9.4906250000000014" style="0" customWidth="1" /> in Debug... and
<x:col min="4" max="4" width="9.830625" style="0" customWidth="1" /> in Resource...
Any ideas what might be wrong?
I tried changing locale to both en-US and en-GB without success, but since there are no textual differences in the files I suppose that would not be the case anyway.
Seems something in the environment could be the issue. But what?
Framework/OS version? Screen resolution?
I attached the output from the test written to C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx
Comments: Hi, it looks like https://closedxml.codeplex.com/SourceControl/network/forks/ericlamb/closedxml/contribution/7561#!/tab/comments broke the tests again.
↧
Commented Unassigned: Lots of tests fails [9422]
Hi
When I clone the source (Git hash: 4cbcac89e85eb03c9cf31ad4162e729db69a596f) and run the tests 95 of the tests fails.
I have not analyzed all of them, just picked the first: AddingDataSet:
```
Test Name: AddingDataSet
Test FullName: ClosedXML_Tests.Examples.MiscTests.AddingDataSet
Test Source: c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs : line 12
Test Outcome: Failed
Test Duration: 0:00:00.972
Result Message:
Actual file 'C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx' is different than the expected file 'Misc.AddingDataSet.xlsx'. The difference is: '/xl/styles.xml :NonEqual
/xl/worksheets/sheet.xml :NonEqual
/xl/worksheets/sheet2.xml :NonEqual
/xl/worksheets/sheet3.xml :NonEqual
'
Expected: True
But was: False
Result StackTrace:
at ClosedXML_Tests.TestHelper.RunTestExample[T](String filePartName) in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\TestHelper.cs:line 83
at ClosedXML_Tests.Examples.MiscTests.AddingDataSet() in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs:line 13
```
I unpacked the ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx and ClosedXML_Tests\Resource\Examples\Misc\AddingDataSet.xlsx by renaming them to zip, unpacking and then comparing them.
In /xl/styles.xml applyNumberFormat="1" is in the Debug... and applyNumberFormat="0" in the Resource...
The same with applyAlignment="1" vs applyAlignment="0".
In /xl/worksheets/sheet.xml and /xl/worksheets/sheet2.xml and /xl/worksheets/sheet3.xml there is the same difference
<x:col min="4" max="4" width="9.4906250000000014" style="0" customWidth="1" /> in Debug... and
<x:col min="4" max="4" width="9.830625" style="0" customWidth="1" /> in Resource...
Any ideas what might be wrong?
I tried changing locale to both en-US and en-GB without success, but since there are no textual differences in the files I suppose that would not be the case anyway.
Seems something in the environment could be the issue. But what?
Framework/OS version? Screen resolution?
I attached the output from the test written to C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx
Comments: Good thing you commented here. I didn't get a notification for your comment over there (11 hours ago). I'll check tomorrow but tests were passing as of my last commit.
When I clone the source (Git hash: 4cbcac89e85eb03c9cf31ad4162e729db69a596f) and run the tests 95 of the tests fails.
I have not analyzed all of them, just picked the first: AddingDataSet:
```
Test Name: AddingDataSet
Test FullName: ClosedXML_Tests.Examples.MiscTests.AddingDataSet
Test Source: c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs : line 12
Test Outcome: Failed
Test Duration: 0:00:00.972
Result Message:
Actual file 'C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx' is different than the expected file 'Misc.AddingDataSet.xlsx'. The difference is: '/xl/styles.xml :NonEqual
/xl/worksheets/sheet.xml :NonEqual
/xl/worksheets/sheet2.xml :NonEqual
/xl/worksheets/sheet3.xml :NonEqual
'
Expected: True
But was: False
Result StackTrace:
at ClosedXML_Tests.TestHelper.RunTestExample[T](String filePartName) in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\TestHelper.cs:line 83
at ClosedXML_Tests.Examples.MiscTests.AddingDataSet() in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs:line 13
```
I unpacked the ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx and ClosedXML_Tests\Resource\Examples\Misc\AddingDataSet.xlsx by renaming them to zip, unpacking and then comparing them.
In /xl/styles.xml applyNumberFormat="1" is in the Debug... and applyNumberFormat="0" in the Resource...
The same with applyAlignment="1" vs applyAlignment="0".
In /xl/worksheets/sheet.xml and /xl/worksheets/sheet2.xml and /xl/worksheets/sheet3.xml there is the same difference
<x:col min="4" max="4" width="9.4906250000000014" style="0" customWidth="1" /> in Debug... and
<x:col min="4" max="4" width="9.830625" style="0" customWidth="1" /> in Resource...
Any ideas what might be wrong?
I tried changing locale to both en-US and en-GB without success, but since there are no textual differences in the files I suppose that would not be the case anyway.
Seems something in the environment could be the issue. But what?
Framework/OS version? Screen resolution?
I attached the output from the test written to C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx
Comments: Good thing you commented here. I didn't get a notification for your comment over there (11 hours ago). I'll check tomorrow but tests were passing as of my last commit.
↧
↧
New Post: Whats different to a file saved in excel?
I recently tried importing an excel file created in ClosedXML into an external system. I received a generic error from their system which I couldn't decipher.
To see if there was an issue with the data I opened the file in excel, then resaved it via Office. I tried importing the file again and it succeeded. I then opened the original file and the "resaved" file in notepad++ and saw that they seemed to be different.
I guess my question is, what would be causing the CLosedXML file to be rejected by the external system? I'd have expected the ClosedXML xlsx file to be the same.
The file sizes were also different. Closed XML was 142kb but "resaving" in excel boosted it to "166Kb".
Is there something I can do to make the files the same without manually resaving it in excel?
Thanks
To see if there was an issue with the data I opened the file in excel, then resaved it via Office. I tried importing the file again and it succeeded. I then opened the original file and the "resaved" file in notepad++ and saw that they seemed to be different.
I guess my question is, what would be causing the CLosedXML file to be rejected by the external system? I'd have expected the ClosedXML xlsx file to be the same.
The file sizes were also different. Closed XML was 142kb but "resaving" in excel boosted it to "166Kb".
Is there something I can do to make the files the same without manually resaving it in excel?
Thanks
↧
New Post: Whats different to a file saved in excel?
Just to explain..I add the following code to work around this issue (shouldn't have to in my opinion)
It effectively opens the file and saves it again
For the record..my code to create the original doc is as simple as
It effectively opens the file and saves it again
Dim excelApp = New Microsoft.Office.Interop.Excel.Application()
Dim excelWb = excelApp.Workbooks.Open(exportToFilePath)
excelWb.Application.DisplayAlerts = False
excelWb.SaveAs(Filename:=exportToFilePath, FileFormat:=Microsoft.Office.Interop.Excel.XlFileFormat.xlOpenXMLWorkbook)
excelWb.Close()
excelApp.Quit()For the record..my code to create the original doc is as simple as
Dim wb As New XLWorkbook()
Dim ws = wb.Worksheets.Add("Changed Products")
ws.Cell(1, 1).InsertTable(changedProducts)
ws.Cell(1, 1).Value = "Product ID"
ws.Cell(1, 2).Value = "SKU"
ws.Cell(1, 3).Value = "EAN"
ws.Cell(1, 4).Value = "MPN"
ws.Cell(1, 5).Value = "Name"
ws.Cell(1, 6).Value = "UPC"
ws.Columns.AdjustToContents() 'Adjust the column widths
wb.Properties.Title = "Changed Data Export"
wb.Properties.Company = "My company"
wb.SaveAs(exportToFilePath) 'Save the file↧
New Post: Inserting Rows without a Loop
Hello!
I've got a problem with inserting rows.
I have an Excel spreadsheet with about 5k rows. I want to insert an additional row after each row that matches a certain criteria and add a formula to it (SUMIF). Doing this in a loop works with small data, but with about 3,5k rows to insert, I always run into an Out Of Memory-exception (because of the recalculation of row numbers and formulas for each iteration).
Is there a better way to accomplish this? From the documentation I've drawn that it is faster to insert them all at once, but if I do this, I can't properly keep track of where they belong (just below the original row) and the data I want them to contain.
I simply cannot wrap my head around this.
Thank you for your help and for creating this awesome library!
-galatyr
I've got a problem with inserting rows.
I have an Excel spreadsheet with about 5k rows. I want to insert an additional row after each row that matches a certain criteria and add a formula to it (SUMIF). Doing this in a loop works with small data, but with about 3,5k rows to insert, I always run into an Out Of Memory-exception (because of the recalculation of row numbers and formulas for each iteration).
Is there a better way to accomplish this? From the documentation I've drawn that it is faster to insert them all at once, but if I do this, I can't properly keep track of where they belong (just below the original row) and the data I want them to contain.
I simply cannot wrap my head around this.
Thank you for your help and for creating this awesome library!
-galatyr
↧
Commented Unassigned: Lots of tests fails [9422]
Hi
When I clone the source (Git hash: 4cbcac89e85eb03c9cf31ad4162e729db69a596f) and run the tests 95 of the tests fails.
I have not analyzed all of them, just picked the first: AddingDataSet:
```
Test Name: AddingDataSet
Test FullName: ClosedXML_Tests.Examples.MiscTests.AddingDataSet
Test Source: c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs : line 12
Test Outcome: Failed
Test Duration: 0:00:00.972
Result Message:
Actual file 'C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx' is different than the expected file 'Misc.AddingDataSet.xlsx'. The difference is: '/xl/styles.xml :NonEqual
/xl/worksheets/sheet.xml :NonEqual
/xl/worksheets/sheet2.xml :NonEqual
/xl/worksheets/sheet3.xml :NonEqual
'
Expected: True
But was: False
Result StackTrace:
at ClosedXML_Tests.TestHelper.RunTestExample[T](String filePartName) in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\TestHelper.cs:line 83
at ClosedXML_Tests.Examples.MiscTests.AddingDataSet() in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs:line 13
```
I unpacked the ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx and ClosedXML_Tests\Resource\Examples\Misc\AddingDataSet.xlsx by renaming them to zip, unpacking and then comparing them.
In /xl/styles.xml applyNumberFormat="1" is in the Debug... and applyNumberFormat="0" in the Resource...
The same with applyAlignment="1" vs applyAlignment="0".
In /xl/worksheets/sheet.xml and /xl/worksheets/sheet2.xml and /xl/worksheets/sheet3.xml there is the same difference
<x:col min="4" max="4" width="9.4906250000000014" style="0" customWidth="1" /> in Debug... and
<x:col min="4" max="4" width="9.830625" style="0" customWidth="1" /> in Resource...
Any ideas what might be wrong?
I tried changing locale to both en-US and en-GB without success, but since there are no textual differences in the files I suppose that would not be the case anyway.
Seems something in the environment could be the issue. But what?
Framework/OS version? Screen resolution?
I attached the output from the test written to C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx
Comments: Sorry, My bad, was to fast updating my code, did not get the last commit where the tests were fixed.
When I clone the source (Git hash: 4cbcac89e85eb03c9cf31ad4162e729db69a596f) and run the tests 95 of the tests fails.
I have not analyzed all of them, just picked the first: AddingDataSet:
```
Test Name: AddingDataSet
Test FullName: ClosedXML_Tests.Examples.MiscTests.AddingDataSet
Test Source: c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs : line 12
Test Outcome: Failed
Test Duration: 0:00:00.972
Result Message:
Actual file 'C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx' is different than the expected file 'Misc.AddingDataSet.xlsx'. The difference is: '/xl/styles.xml :NonEqual
/xl/worksheets/sheet.xml :NonEqual
/xl/worksheets/sheet2.xml :NonEqual
/xl/worksheets/sheet3.xml :NonEqual
'
Expected: True
But was: False
Result StackTrace:
at ClosedXML_Tests.TestHelper.RunTestExample[T](String filePartName) in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\TestHelper.cs:line 83
at ClosedXML_Tests.Examples.MiscTests.AddingDataSet() in c:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\Examples\MiscTests.cs:line 13
```
I unpacked the ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx and ClosedXML_Tests\Resource\Examples\Misc\AddingDataSet.xlsx by renaming them to zip, unpacking and then comparing them.
In /xl/styles.xml applyNumberFormat="1" is in the Debug... and applyNumberFormat="0" in the Resource...
The same with applyAlignment="1" vs applyAlignment="0".
In /xl/worksheets/sheet.xml and /xl/worksheets/sheet2.xml and /xl/worksheets/sheet3.xml there is the same difference
<x:col min="4" max="4" width="9.4906250000000014" style="0" customWidth="1" /> in Debug... and
<x:col min="4" max="4" width="9.830625" style="0" customWidth="1" /> in Resource...
Any ideas what might be wrong?
I tried changing locale to both en-US and en-GB without success, but since there are no textual differences in the files I suppose that would not be the case anyway.
Seems something in the environment could be the issue. But what?
Framework/OS version? Screen resolution?
I attached the output from the test written to C:\Git\closedxml\ClosedXML\ClosedXML\ClosedXML_Tests\bin\Debug\Examples\Misc\AddingDataSet.xlsx
Comments: Sorry, My bad, was to fast updating my code, did not get the last commit where the tests were fixed.
↧
↧
New Post: Inserting Rows without a Loop
1) Compile your app to 64 bits (to get rid of Out of Memory exception)
2) Turn off events (to speed up the process)
var wb = new XLWorkbook(XLEventTracking.Disabled);
https://closedxml.codeplex.com/wikipage?title=Turning%20off%20events&referringTitle=Documentation
2) Turn off events (to speed up the process)
var wb = new XLWorkbook(XLEventTracking.Disabled);
https://closedxml.codeplex.com/wikipage?title=Turning%20off%20events&referringTitle=Documentation
↧
New Post: IntegerExtension.ToStringLookup not threadsafe?
We'll give it a shot and see if the issue is resolved. Thanks!
↧
Created Unassigned: Improve performance [9425]
Hi
There is room for performance improvements in ClosedXML.
To create a performance base line I updated the sandbox example in the branch https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml?branch=Performance_Example to create a Excel document similar to our production code
(See change set https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/changeset/6aedcc8946cc210a4f81224f8e65f2f4feb0ee10 )
I created a pull request with some low hanging fruit fixes: https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/contribution/8065
Before the pull request the execution time on my computer was 9.8 seconds, with the pull request applied the execution time was 6.7 seconds. That's an overall 30% improvement on a generate + save cycle.
I have some further fixes in the works, I'll add comments to this issue when the are ready.
// Albin Sunnanbo @ Kentor
There is room for performance improvements in ClosedXML.
To create a performance base line I updated the sandbox example in the branch https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml?branch=Performance_Example to create a Excel document similar to our production code
(See change set https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/changeset/6aedcc8946cc210a4f81224f8e65f2f4feb0ee10 )
I created a pull request with some low hanging fruit fixes: https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/contribution/8065
Before the pull request the execution time on my computer was 9.8 seconds, with the pull request applied the execution time was 6.7 seconds. That's an overall 30% improvement on a generate + save cycle.
I have some further fixes in the works, I'll add comments to this issue when the are ready.
// Albin Sunnanbo @ Kentor
↧
New Post: Whats different to a file saved in excel?
Anyone able to help? I'm trying to find a way of not adding COM references to my solution before it's release today.
↧
↧
Source code checked in, #969c276db667d0ff5b2707ef9627254db572dd95
Merge branch 'PerformanceImprovementsCombined' of https://git01.codeplex.com/forks/albinsunnanbo/closedxml into AlbinSunnanbo/closedxml
↧
Source code checked in, #ad7bfc93620a1b0fee59fb0689ab4a7d27ea58c1
IsMerge is now faster.
↧
Commented Unassigned: Improve performance [9425]
Hi
There is room for performance improvements in ClosedXML.
To create a performance base line I updated the sandbox example in the branch https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml?branch=Performance_Example to create a Excel document similar to our production code
(See change set https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/changeset/6aedcc8946cc210a4f81224f8e65f2f4feb0ee10 )
I created a pull request with some low hanging fruit fixes: https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/contribution/8065
Before the pull request the execution time on my computer was 9.8 seconds, with the pull request applied the execution time was 6.7 seconds. That's an overall 30% improvement on a generate + save cycle.
I have some further fixes in the works, I'll add comments to this issue when the are ready.
// Albin Sunnanbo @ Kentor
Comments: More low hanging fruit: cell.IsMerged doesn't cast to range now. https://closedxml.codeplex.com/SourceControl/changeset/ad7bfc93620a1b0fee59fb0689ab4a7d27ea58c1
There is room for performance improvements in ClosedXML.
To create a performance base line I updated the sandbox example in the branch https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml?branch=Performance_Example to create a Excel document similar to our production code
(See change set https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/changeset/6aedcc8946cc210a4f81224f8e65f2f4feb0ee10 )
I created a pull request with some low hanging fruit fixes: https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/contribution/8065
Before the pull request the execution time on my computer was 9.8 seconds, with the pull request applied the execution time was 6.7 seconds. That's an overall 30% improvement on a generate + save cycle.
I have some further fixes in the works, I'll add comments to this issue when the are ready.
// Albin Sunnanbo @ Kentor
Comments: More low hanging fruit: cell.IsMerged doesn't cast to range now. https://closedxml.codeplex.com/SourceControl/changeset/ad7bfc93620a1b0fee59fb0689ab4a7d27ea58c1
↧
Commented Unassigned: Improve performance [9425]
Hi
There is room for performance improvements in ClosedXML.
To create a performance base line I updated the sandbox example in the branch https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml?branch=Performance_Example to create a Excel document similar to our production code
(See change set https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/changeset/6aedcc8946cc210a4f81224f8e65f2f4feb0ee10 )
I created a pull request with some low hanging fruit fixes: https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/contribution/8065
Before the pull request the execution time on my computer was 9.8 seconds, with the pull request applied the execution time was 6.7 seconds. That's an overall 30% improvement on a generate + save cycle.
I have some further fixes in the works, I'll add comments to this issue when the are ready.
// Albin Sunnanbo @ Kentor
Comments: Hi, thanks for the merge. I had also noticed the IsMerged issue. I had note found the Contains(IXLCell cell) overload, I hade an idea of creating an overload Intersects(IXLCell cell) but this is obviously much more elegant. With your fix for IsMerged my test example runs in 5.9 seconds. 40% reduction from a before the fixes!
There is room for performance improvements in ClosedXML.
To create a performance base line I updated the sandbox example in the branch https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml?branch=Performance_Example to create a Excel document similar to our production code
(See change set https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/changeset/6aedcc8946cc210a4f81224f8e65f2f4feb0ee10 )
I created a pull request with some low hanging fruit fixes: https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/contribution/8065
Before the pull request the execution time on my computer was 9.8 seconds, with the pull request applied the execution time was 6.7 seconds. That's an overall 30% improvement on a generate + save cycle.
I have some further fixes in the works, I'll add comments to this issue when the are ready.
// Albin Sunnanbo @ Kentor
Comments: Hi, thanks for the merge. I had also noticed the IsMerged issue. I had note found the Contains(IXLCell cell) overload, I hade an idea of creating an overload Intersects(IXLCell cell) but this is obviously much more elegant. With your fix for IsMerged my test example runs in 5.9 seconds. 40% reduction from a before the fixes!
↧
↧
Commented Unassigned: Improve performance [9425]
Hi
There is room for performance improvements in ClosedXML.
To create a performance base line I updated the sandbox example in the branch https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml?branch=Performance_Example to create a Excel document similar to our production code
(See change set https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/changeset/6aedcc8946cc210a4f81224f8e65f2f4feb0ee10 )
I created a pull request with some low hanging fruit fixes: https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/contribution/8065
Before the pull request the execution time on my computer was 9.8 seconds, with the pull request applied the execution time was 6.7 seconds. That's an overall 30% improvement on a generate + save cycle.
I have some further fixes in the works, I'll add comments to this issue when the are ready.
// Albin Sunnanbo @ Kentor
Comments: Shaved another hair: https://closedxml.codeplex.com/SourceControl/changeset/cb669076253e069f7a6f66a63a94c73bdf43f523 I'm not analyzing much, just profiling and improving the first thing that pops up...
There is room for performance improvements in ClosedXML.
To create a performance base line I updated the sandbox example in the branch https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml?branch=Performance_Example to create a Excel document similar to our production code
(See change set https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/changeset/6aedcc8946cc210a4f81224f8e65f2f4feb0ee10 )
I created a pull request with some low hanging fruit fixes: https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/contribution/8065
Before the pull request the execution time on my computer was 9.8 seconds, with the pull request applied the execution time was 6.7 seconds. That's an overall 30% improvement on a generate + save cycle.
I have some further fixes in the works, I'll add comments to this issue when the are ready.
// Albin Sunnanbo @ Kentor
Comments: Shaved another hair: https://closedxml.codeplex.com/SourceControl/changeset/cb669076253e069f7a6f66a63a94c73bdf43f523 I'm not analyzing much, just profiling and improving the first thing that pops up...
↧
Source code checked in, #cb669076253e069f7a6f66a63a94c73bdf43f523
Cache ToInvariantString
↧
Commented Unassigned: Improve performance [9425]
Hi
There is room for performance improvements in ClosedXML.
To create a performance base line I updated the sandbox example in the branch https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml?branch=Performance_Example to create a Excel document similar to our production code
(See change set https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/changeset/6aedcc8946cc210a4f81224f8e65f2f4feb0ee10 )
I created a pull request with some low hanging fruit fixes: https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/contribution/8065
Before the pull request the execution time on my computer was 9.8 seconds, with the pull request applied the execution time was 6.7 seconds. That's an overall 30% improvement on a generate + save cycle.
I have some further fixes in the works, I'll add comments to this issue when the are ready.
// Albin Sunnanbo @ Kentor
Comments: I made another pull request in https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/contribution/8072 with a small improvement for XLCell.SetValue(object value)
There is room for performance improvements in ClosedXML.
To create a performance base line I updated the sandbox example in the branch https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml?branch=Performance_Example to create a Excel document similar to our production code
(See change set https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/changeset/6aedcc8946cc210a4f81224f8e65f2f4feb0ee10 )
I created a pull request with some low hanging fruit fixes: https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/contribution/8065
Before the pull request the execution time on my computer was 9.8 seconds, with the pull request applied the execution time was 6.7 seconds. That's an overall 30% improvement on a generate + save cycle.
I have some further fixes in the works, I'll add comments to this issue when the are ready.
// Albin Sunnanbo @ Kentor
Comments: I made another pull request in https://closedxml.codeplex.com/SourceControl/network/forks/AlbinSunnanbo/closedxml/contribution/8072 with a small improvement for XLCell.SetValue(object value)
↧